From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 28 Aug 2014 14:22:49 +0000 (+0200)
Subject: workspace: Always remove removed windows
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2222
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=c9f3afc38fef7fde3791cdbabae5ac66c2e6c03c;p=gnome-shell.git

workspace: Always remove removed windows

Since mutter commit 527c53a2a0582eba, MetaWorkspace::window-removed
is emitted *before* MetaWindow:workspace is updated, so the test
whether the removed window should still be on the workspace in
question will always return true.
Assume the test is no longer necessary nowadays to fix this very
obvious regression.

https://bugzilla.gnome.org/show_bug.cgi?id=735608
---

diff --git a/js/ui/workspace.js b/js/ui/workspace.js
index ddd043110..66058b93d 100644
--- a/js/ui/workspace.js
+++ b/js/ui/workspace.js
@@ -1417,10 +1417,6 @@ const Workspace = new Lang.Class({
         if (index == -1)
             return;
 
-        // Check if window still should be here
-        if (win && this._isMyWindow(win))
-            return;
-
         let clone = this._windows[index];
 
         this._windows.splice(index, 1);
diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index c11d13bd1..0455a9dd6 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -367,10 +367,6 @@ const WorkspaceThumbnail = new Lang.Class({
         if (index == -1)
             return;
 
-        // Check if window still should be here
-        if (win && this._isMyWindow(win) && this._isOverviewWindow(win))
-            return;
-
         let clone = this._windows[index];
         this._windows.splice(index, 1);